S3 reading support#198
Draft
Bisaloo wants to merge 8 commits into
Draft
Conversation
Bisaloo
commented
May 15, 2026
| .readLayer <- \(l) { | ||
| j <- list.dirs(file.path(x, l), recursive=FALSE, full.names=TRUE) | ||
| names(j) <- basename(j) | ||
| message(" reading ", l, "...") |
Collaborator
Author
There was a problem hiding this comment.
I put this for now because S3 reading is quite slow and I wanted to see what was happening but I don't usually love super verbose functions.
Comment on lines
+55
to
+56
| # Until we have a complete store interface (https://github.com/Huber-group-EMBL/Rarr/pull/176), | ||
| # only local objects can be fully validated. |
Collaborator
Author
There was a problem hiding this comment.
This will be handled by rome eventually anyways.
Bisaloo
force-pushed
the
s3-read
branch
2 times, most recently
from
2df1075 to
4d35c5b
Compare
Bisaloo
commented
May 15, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tableselement, as this needs to be implemented separately in anndataR. Prerequisite: Consolidated Zarr metadata at the root of the anndata zarr store scverse/anndataR#461)