Skip to content

Added kerb type quest #936#937

Open
SPLATPLAYS wants to merge 3 commits intoHelium314:modifiedfrom
SPLATPLAYS:modified
Open

Added kerb type quest #936#937
SPLATPLAYS wants to merge 3 commits intoHelium314:modifiedfrom
SPLATPLAYS:modified

Conversation

@SPLATPLAYS
Copy link
Copy Markdown

Solved #936 by adding a quest for kerbs as ways.

@Helium314
Copy link
Copy Markdown
Owner

There are a few things to consider:

  • SCEE quests should be disabled by default
  • SCEE quests go to SCEE section in QuestsModule, with the offset to avoid collision with SC quests
  • SCEE strings should go to strings_ee (and use strings in androidMain as base as long as strings are still duplicated)
  • Why duplicate KerbHeight with different names for the same tags?
  • In the issue you wrote may often be “raised”. How much do you expect to be raised? (see https://github.com/Helium314/SCEE/blob/modified/QUEST_GUIDELINES.md#users)

SPLATPLAYS and others added 2 commits April 15, 2026 11:35
…led by default, fixed different names for the same tags in comparison to kerb height.
@SPLATPLAYS
Copy link
Copy Markdown
Author

@Helium314 Thanks so much for the comment, I have updated the pr with the changes requested. I expect kerbs to be raised 30-40% of the time but there is generally a lot of variation so I couldn't tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants