Dev/gabriel souki#1211
Open
soukigabriel wants to merge 45 commits into
Open
Conversation
… to its own folder with its own providers by domain.
… Working on VersesBundle interaction workflow refactor.
…State Machine. tryHighlightPieceMethod of PieceHighlightService completed.
… the highlight FSM pattern.
…cohesively. Added methods to PieceLabelService and LabelFeedbackAdapter to change the label's intensity.
…cripture map 2D selects it in the reader.
…tackBookBaseData class. Refactored the selection logic for many stack entities to use a FSM pattern. Wrote tests for entities in Bible Visualization Utils/domain/entities and services at Bible Visualization Utils/application/services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging with Scripture Map 2D in a functional state. User presence and UI design are a work in progress.