Repository navigation
Conversation
|
👋 Welcome, @GallaGit, and thanks for opening your first PR on AnythingMCP! A few quick pointers:
Someone from the core team will look at this within ~48h. If you don't hear back, please ping us in Discussions / Q&A. ⭐ While you wait — if you find AnythingMCP useful, a star helps others discover it. |
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
helpcodeai
left a comment
There was a problem hiding this comment.
Thanks @GallaGit. Going with CLI flags instead of a ?serverUrl= link is the right call given how the v2 token works. I checked it against the 2.10.1 package: --server-url, --transport http and --header are all accepted, the engines field says Node >= 22.19, and the Inspector injects its token into the page even at the bare http://localhost:6274/ URL, so the plain link and the sentence in the modal are accurate. Nothing secret goes into a URL, and inspectorCommand only ever gets the endpoint the page already shows.
I ran it locally: frontend tsc and lint are clean, and the whole Playwright suite passes (131 tests, your two new ones included).
Some non-blocking notes, fine to merge without them:
.env.exampledefaults toMCP_AUTH_MODE=oauth2and the modal tells people to sign in with OAuth. If you get a minute, try that path once (the Inspector registershttp://localhost:6274/oauth/callback, which our DCR accepts as a loopback URI) and add a line to the PR about how it went.--header "X-API-Key: ..."leaves the key in shell history. Maybe mention the Inspector's own header field first and the flag second.inspector-url.tsand the e2e spec are missing the trailing newline.
CI on fork PRs has to be started by us, so that part's on our side. It's good to go once it's green.
…add trailing newlines
|
Thanks a lot for the thorough review and for running the suite! I pushed a small follow-up: the modal now suggests the Inspector's own header field first and the |
|
Tried the OAuth path: with |


Closes #1002.
What
npx @modelcontextprotocol/inspector --server-url "<endpoint>" --transport http, plus a plain link to the local Inspector (http://localhost:6274/) and sign-in steps (OAuth orX-API-Key).packages/frontend/src/lib/inspector-url.tsbuilds the command; only the server URL goes in, never keys or tokens.mcp-server-connect-clients.spec.ts(cloud and self-hosted).Why CLI flags instead of a
?serverUrl=deep linkAs discussed in the issue, Inspector v2 ignores
serverUrldeep links unless they also carry the per-launch session token, which is secret. Pre-filling through CLI flags avoids putting any credential in a URL, and the Inspector hands its own token to the page it opens.Testing
Manually tested locally with Docker: Quick Connect modal shows the pre-filled command; Inspector v2.10.1 connects with X-API-Key and tools/list succeeds.
Lint and TypeScript are clean on the touched files.