Quieter Redis, sharper marketplace search, clearer adapter install - #797
Merged
Merged
Conversation
- Redis: without REDIS_URL no client is created. The localhost:6379 fallback made every default self-hosted install retry forever and log a warning every two seconds. Connection errors are now logged once per distinct error, with a line when the connection comes back; health tells 'not configured' apart from 'configured but unreachable'. - Marketplace search: every word must start a word (camelCase and letter/digit humps count). 'SAP' no longer returns WhatsApp, MessageBird and NewsAPI; 'api' still finds NewsAPI, 'hana' finds S/4HANA. - Install modal: adapters whose base URL is built from variables (SAP HANA) no longer offer 'Skip for now', which always failed with a 400 after the modal had closed. A failed import keeps the modal open and shows the error there. Code blocks in the instructions wrap instead of running past the edge. - Connector page: long endpoint paths (the SQL of database tools) collapse to one line with a 'Show full SQL' toggle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five things found while taking screenshots on a fresh self-hosted instance (default docker-compose.yml, v0.15.x).
1. Redis log spam. With
REDIS_URLunset,RedisServicefell back toredis://localhost:6379; ioredis then retried forever and loggedRedis connection errorevery ~2 s (about 40k lines a day on every default install, where Redis is commented out). Now no client is created withoutREDIS_URL(one info line at boot), errors are logged once per distinct message with a "restored" line on recovery, and/healthsays "Configured but not reachable" vs "Not configured (optional)" (status staysupin both, as before). Cloud setsREDIS_URLexplicitly (checked on the droplet), so it is unaffected. Only a dev who runs a local Redis without settingREDIS_URLloses the implicit default. Newredis.service.spec.ts.2. Marketplace search matched substrings. "SAP" returned WhatsApp, MessageBird ("WhatsApp via Bird") and NewsAPI. Now every query word must start a word; camelCase and letter/digit humps count, and the text as written still matches. Checked: SAP → 5 adapters (was 8),
api→ NewsAPI still found,hana/4hana/S/4HANA→ the S/4HANA adapters,e-commerce,germany, multi-wordsap erpwork. Helper insrc/lib/marketplace-search.ts.3. "Skip for now" on SAP S/4HANA (HANA SQL) always failed. Its base URL is
hana://{{SAP_HANA_HOST}}:{{SAP_HANA_PORT}}/..., so the backend rightly refuses to create it (400), but the modal had already closed and the error landed in a banner at the top. Adapters whose base URL has placeholders no longer offer Skip, and the modal says which fields form the address. Any failed import now keeps the modal open and shows the error inside it. Adapters without URL variables (e.g. NewsAPI) still offer Skip.4. Install instructions overflowed. Fenced SQL (
CREATE USER AMCP_READER ...) ran past the modal edge; code blocks in the modal now wrap.5. Tool cards printed the full SQL. Database tools showed the whole statement wrapped mid-word (
break-all), 40 lines per card on the HANA adapter. Paths over 120 chars or multi-line now show one line with a "Show full SQL" toggle.Tested: backend tsc + new spec (3/3); frontend tsc + eslint (no new warnings); in a browser against a local instance: search counts above, HANA modal (no Skip, explanation, wrapped SQL), forced 400 on import keeps the modal open with the error, NewsAPI still has Skip, 8/10 HANA tools collapsed and expand on click, no page errors.