Probe generialized implementation#98
Closed
nicolaefilat wants to merge 68 commits into
Closed
Conversation
Tests do not pass. Implementation is also probably to inefficient
Co-authored-by: Nils Mikk <nilsmikk@gmail.com>
Remove hardcoded selectpsol function
Add all 3 selection functions for probe and wrote tests
Remove old iterator
…b-AI/HerbSearch.jl into grammar-update-probabilities
…b-AI/HerbSearch.jl into grammar-update-probabilities
Co-authored-by: Nicolae Filat,
…the left over sum directly.
Refactor benchmark file
Co-authored-by: Nils Mikk <nilsmikk@gmail.com>
…tside the if then else Remove unused `programs` field
The ProgramCache struct and evaluation function is moved to probe_utilities.jl
Contributor
Author
|
I did a bit of a hack to add the HerbGrammar |
Fix some typos and remove commented out lines.
Member
Please switch this back, @nicolaefilat. We don't want to mess with the CI to make it pass. We'll get the |
Contributor
Author
|
@ReubenJ I reverted the CI hack :) |
…tation. Update grammar now works with log base e probabilities.
Member
Hackathon PlanSteps
Optimization
|
Closed
Member
|
Closing this in favor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ask for code review to check if the implementation is up to standards.
It requires HerbGrammar to be on branch
fix-normalizingto pass tests.