Skip to content

Probe generialized implementation#98

Closed
nicolaefilat wants to merge 68 commits into
masterfrom
probe
Closed

Probe generialized implementation#98
nicolaefilat wants to merge 68 commits into
masterfrom
probe

Conversation

@nicolaefilat
Copy link
Copy Markdown
Contributor

@nicolaefilat nicolaefilat commented May 13, 2024

We ask for code review to check if the implementation is up to standards.

It requires HerbGrammar to be on branch fix-normalizing to pass tests.

nicolaefilat and others added 30 commits April 29, 2024 21:42
Tests do not pass.
Implementation is also probably to inefficient
Co-authored-by: Nils Mikk <nilsmikk@gmail.com>
Add all 3 selection functions for probe and wrote tests
Co-authored-by: Nicolae Filat,
Co-authored-by: Nils Mikk <nilsmikk@gmail.com>
…tside the if then else

Remove unused `programs` field
@nicolaefilat
Copy link
Copy Markdown
Contributor Author

I did a bit of a hack to add the HerbGrammar fix-normalizing branch to the CI as a dependency to make the CI pass to prove that the code works :)

@nicolaefilat nicolaefilat marked this pull request as ready for review July 14, 2024 12:55
@ReubenJ
Copy link
Copy Markdown
Member

ReubenJ commented Jul 15, 2024

I did a bit of a hack to add the HerbGrammar fix-normalizing branch to the CI as a dependency to make the CI pass to prove that the code works :)

Please switch this back, @nicolaefilat. We don't want to mess with the CI to make it pass. We'll get the HerbGrammar branch merged and released before merging this.

@nicolaefilat
Copy link
Copy Markdown
Contributor Author

@ReubenJ I reverted the CI hack :)

Base automatically changed from dev to master October 3, 2024 12:28
@ReubenJ
Copy link
Copy Markdown
Member

ReubenJ commented Oct 23, 2024

Hackathon Plan

Steps

  • Run a budgeted search
    • Gets an iterator with some limit (the low-level budget)
    • This is a normal iterator
  • Collect (partial) successes
    • Function to define success, which is just % of examples solved by default
    • Function takes any kind of specification
    • Boolean output: should the program be saved or not?
  • Modify the grammar
    • Function to modify the grammar based on the successes
    • Takes the successes (saved programs)
    • Modify the grammar: in place or return a new one, TBD
  • Rinse and repeat
    • Function defining high-level budget
    • For now, just a parameter defining the number of overall runs of budgeted search

Optimization

  • When evaluating a program during search, store the output of a rulenode on the specification in the rulenode's _val field
  • Keep queue across grammar updates to avoid re-enumerating the search space that was already explored earlier

@ReubenJ ReubenJ mentioned this pull request Oct 23, 2024
@THinnerichs THinnerichs self-assigned this Nov 22, 2024
@THinnerichs
Copy link
Copy Markdown
Member

Closing this in favor of MLFIterator and Herb-AI/Garden.jl#5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants