Skip to content

Global Filter for comprehensive search for artifacts, executions and label content.#294

Closed
varkha-d-sharma wants to merge 13 commits into
HewlettPackard:masterfrom
varkha-d-sharma:clear
Closed

Global Filter for comprehensive search for artifacts, executions and label content.#294
varkha-d-sharma wants to merge 13 commits into
HewlettPackard:masterfrom
varkha-d-sharma:clear

Conversation

@varkha-d-sharma

Copy link
Copy Markdown
Collaborator

Related Issues / Pull Requests

List all related issues and/or pull requests if there are any.

Description

Include a brief summary of the proposed changes.

What changes are proposed in this pull request?

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected; for instance,
    examples in this repository need to be updated too).
  • This change requires a documentation update.

Checklist:

  • My code follows the style guidelines of this project (PEP-8 with Google-style docstrings).
  • My code modifies existing public API, or introduces new public API, and I updated or wrote docstrings that
    uses Google-style formatting and any other formatting that is supported by mkdocs and plugins this project
    uses.
  • I have commented my code.
  • My code requires documentation updates, and I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Comment thread server/app/utils.py Outdated
Comment thread server/app/db/dbqueries.py Outdated
Comment thread server/app/db/dbmodels.py
label_content = Table(
"label_content", metadata,
Column("id", Integer, primary_key=True, autoincrement=True, nullable=False),
Column("artifact_id", Integer, nullable=False),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this artifact_id of the dataset associated with the label ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the id of this label in the artifact table.

@AyeshaSanadi

Copy link
Copy Markdown
Collaborator

Added changes of this PR inside #353 pr.

@AyeshaSanadi

Copy link
Copy Markdown
Collaborator

#353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants