Skip to content

fix: macos, launch ida also if path is not an app bundle #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acohex wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −4
Open

fix: macos, launch ida also if path is not an app bundle #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/hcli/lib/ida/launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,10 @@ def report(msg: str) -> None:
ida_bin_str = str(ida_bin)
if "/Contents/MacOS/" in ida_bin_str:
app_bundle = ida_bin_str.split("/Contents/MacOS/")[0]
cmd = ["open", "-n", "-a", app_bundle, "--args", str(idb_path)]
if app_bundle.endswith(".app"):
cmd = ["open", "-n", "-a", app_bundle, "--args", str(idb_path)]
else:
cmd = [ida_bin_str, str(idb_path)]
else:
cmd = [ida_bin_str, str(idb_path)]
else:
Expand Down Expand Up @@ -313,15 +316,20 @@ def report(msg: str) -> None:

# Launch IDA process
# On macOS, use 'open -a' to launch via LaunchServices, which escapes
# any sandbox restrictions from protocol handlers
# any sandbox restrictions from protocol handlers. Only works when the
# bundle is named *.app — otherwise fall back to invoking the binary
# directly.
if sys.platform == "darwin":
# Extract .app bundle path from binary path
# e.g., /Applications/IDA.app/Contents/MacOS/ida -> /Applications/IDA.app
ida_bin_str = str(ida_bin)
if "/Contents/MacOS/" in ida_bin_str:
app_bundle = ida_bin_str.split("/Contents/MacOS/")[0]
# Use -n to force a new instance, --args to pass the IDB path
cmd = ["open", "-n", "-a", app_bundle, "--args", str(idb_path)]
if app_bundle.endswith(".app"):
# Use -n to force a new instance, --args to pass the IDB path
cmd = ["open", "-n", "-a", app_bundle, "--args", str(idb_path)]
else:
cmd = [ida_bin_str, str(idb_path)]
else:
cmd = [ida_bin_str, str(idb_path)]
else:
Expand Down
Loading