Merged
Conversation
added 30 commits
March 26, 2025 20:26
…pe into ground-intake
| public static final double INTAKE_ALGAE_HIGH_EXTENSION = Units.inchesToMeters(35.0); | ||
|
|
||
| public static final double ALGAE_NET_EXTENSION = Units.inchesToMeters(61.5); | ||
| // 1 inch high (maybe not needed?) |
Contributor
There was a problem hiding this comment.
the elevator is already maxed out i believe
Contributor
Author
There was a problem hiding this comment.
It was close, but the max in code was 2 inches higher
Contributor
Author
|
I've looked at the new setpoints with new EE vis and it looks pretty good, but the shooting speed on the may need to be lowered. |
Lyssia-Seiden
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to tune this using sim as best I could, but my vis uses the old effector so it was a little difficult. Will need tuning in person. I also might need to move the autoalign target.