perf/maint: use custom Detic repo with embeddig caching#63
Merged
Conversation
HiroIshida
force-pushed
the
use_custom_detic_repo
branch
from
b21ac5d to
56a02e9
Compare
mqcmd196
pushed a commit
to mqcmd196/detic_ros
that referenced
this pull request
May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is to incorporate this PR facebookresearch/Detic#123
which resolves the bottlenecks in vocabulary changing.
@mqcmd196
This PR, (hopefully) temporary, pointing to my Detic-repo to reflect this change.
I will re-point to Detic original repo, once the PRs are merged