Add cross-table chip transfer with fee (Issue #208) - #472
Merged
Marvy247 merged 2 commits intoAug 29, 2026
Conversation
Add verifiable random function (VRF) to the deal circuit. - Prove that the shuffle seed was derived from a VRF output - Enables public verifiability of randomness Changes: - circuits/lib/src/vrf.nr: New VRF module with prove/verify functions - circuits/lib/src/lib.nr: Expose VRF module - circuits/deal_valid/src/main.nr: Accept VRF inputs, derive shuffle seed - circuits/deal_valid_2p/5p/6p/src/main.nr: Update parameterized circuits
- New API endpoint POST /api/table/:table_id/transfer-chips - Allows players to transfer chips between tables they are seated at - Deducts a configurable fee (default 1% = 100 basis points) from transferred amount - Validates player is seated at both source and destination tables - Validates sufficient chip balance at source table - Invokes Soroban contract transfer_chips function on-chain - Emits TransferEvents via audit logging - Includes OpenAPI documentation and request/response types
|
@MarcusDavidG Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements cross-table chip transfers as requested in Issue #208, allowing players to transfer chips between tables they are seated at with a small fee deducted.
Changes
New API Endpoint
Request/Response Types (api/types.rs)
Soroban Integration (soroban/actions.rs)
API Logic (api/mod.rs)
Configuration
Testing
The implementation follows existing patterns in the codebase:
Notes
The on-chain contract must implement a function with the expected interface:
Closes #208