Fix legacy blocks resolving to air in Bedrock worlds#2440
Open
LVCHLANN wants to merge 1 commit into
Open
Conversation
Worlds with blocks not converted by the 1.13 major update still have some old numeric id's, even when the world itself itself is a modern version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with legacy chunks not being fully upgraded, I had just upgraded a world from an old version (within Minecraft, not chunker) which still had legacy numeric id's, Which when converted to java in my case left air instead of the relevant blocks, this simply adds a check for legacy blocks, and when detected, falls back to the legacy resolver used for worlds before 1.13
It does this by looking for
valtags which only existed in legacy versions of the game (Legacy Console Edition, all pre 1.13 versions e.t.c.) and then defaults them to the legacy resolver