Localize Hotbar setup wizard#3785
Open
nightt5879 wants to merge 1 commit into
Open
Conversation
Route Hotbar setup title, source tabs, status text, help text, slot labels, and validation errors through localization IDs. Localize built-in App hotbar action names/descriptions and the reasoning auto-routing disabled reason so non-English setup views are not dominated by English action rows. Add shipped-locale strings and zh-Hant Hotbar command/keybinding coverage tests for issue Hmbown#3759. Verification: cargo fmt --all; cargo test -p codewhale-tui --bin codewhale-tui --locked hotbar; cargo test -p codewhale-tui --bin codewhale-tui --locked localization; cargo test -p codewhale-tui --bin codewhale-tui --locked; cargo build --release -p codewhale-cli -p codewhale-tui --locked. cargo test --workspace --locked still hits unrelated core::engine::tests::edit_last_turn_preserves_current_mode snapshot timeout locally; that test passes in isolation.
5 tasks
Owner
|
Thanks @nightt5879. This localization pass is useful, but it is broad enough that I do not want to rush it into the 0.8.67 final cut while it conflicts with current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3759.
Summary
Verification
cargo fmt --allcargo test -p codewhale-tui --bin codewhale-tui --locked hotbarcargo test -p codewhale-tui --bin codewhale-tui --locked localizationcargo test -p codewhale-tui --bin codewhale-tui --lockedcargo build --release -p codewhale-cli -p codewhale-tui --lockedNotes
cargo test --workspace --lockedrepeatedly hitcore::engine::tests::edit_last_turn_preserves_current_modewithsnapshot response: Elapsed(()); that test passes in isolation withcargo test -p codewhale-tui --bin codewhale-tui --locked core::engine::tests::edit_last_turn_preserves_current_mode -- --exact.