Skip to content

refactor(shell): split output buffer helpers#3973

Open
cyq1017 wants to merge 1 commit into
Hmbown:mainfrom
cyq1017:codex/codewhale-3958-shell-output-helpers
Open

refactor(shell): split output buffer helpers#3973
cyq1017 wants to merge 1 commit into
Hmbown:mainfrom
cyq1017:codex/codewhale-3958-shell-output-helpers

Conversation

@cyq1017

@cyq1017 cyq1017 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Refs #3958

Summary

  • move shell output delta and tail buffer helpers into tools/shell/output.rs
  • keep exec/wait/interact tool schemas and shell dispatch behavior unchanged
  • keep approval, sandbox, timeout, and background-job behavior unchanged

Verification

  • cargo fmt --check
  • cargo test -p codewhale-tui --bin codewhale-tui --locked shell

@Hmbown

Hmbown commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Thanks @cyq1017. This looks like a clean behavior-preserving shell refactor, but it is still draft and its tracking issue is already routed to v0.8.68. I am going to leave it out of the 0.8.67 cut and pick it back up after release once it is ready for review. No harvest needed unless the branch gets stale.

@cyq1017 cyq1017 marked this pull request as ready for review July 3, 2026 23:44
@cyq1017 cyq1017 requested a review from Hmbown as a code owner July 3, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants