Fixed issue #183.#192
Merged
Merged
Conversation
with '' will be ignored, and an empty message aborts the commit. On branch dev Your branch is up to date with 'origin/dev'. Changes to be committed: new file: build-musl.sh new file: build.sh
… lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche dev Votre branche est à jour avec 'origin/dev'. Modifications qui seront validées : supprimé : build-musl.sh supprimé : build.sh
Veuillez saisir le message de validation pour vos modifications. Les lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche dev Votre branche est à jour avec 'origin/dev'. Modifications qui seront validées : nouveau fichier : deps.txt
… lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche dev Votre branche est en avance sur 'origin/dev' de 1 commit. (utilisez "git push" pour publier vos commits locaux) Modifications qui seront validées : modifié : src/lufus/writing/install_ventoy.py modifié : src/lufus/writing/windows/flash.py modifié : src/lufus/writing/windows/tweaks.py
…st go and explain how this works :D So, I made a small worker that starts before PKEXEC, logs XDG_DOWNLOAD_DIR (or ~/ if XDG_DOWNLOAD_DIR doesn't exist) to a variable, passes it to the app running as root before exiting in nanoseconds. The file manager from the GUI automatically takes the content of the variable as default directory. Made sure utils.py doesn't erase the variable. I also made tests (including edge cases), ruff-formatted and tested. Sur la branche dev Votre branche est à jour avec 'origin/dev'. Modifications qui seront validées : modifié : src/lufus/gui/gui.py modifié : src/lufus/gui/start_gui.py nouveau fichier : src/lufus/user_paths.py modifié : src/lufus/utils.py nouveau fichier : tests/test_user_paths.py
P.S. From the provious commit and this one, NO AI USED! Sur la branche dev Votre branche est à jour avec 'origin/dev'. Modifications qui seront validées : modifié : .github/workflows/ci.yml
Veuillez saisir le message de validation pour vos modifications. Les lignes commençant par '' seront ignorées, et un message vide abandonne la validation. Sur la branche dev Votre branche est à jour avec 'origin/dev'. Modifications qui seront validées : modifié : install_ventoy.py modifié : windows/flash.py modifié : windows/tweaks.py
Contributor
Author
|
There were some changes I forgot to remove from wrong commits, they are fixed now! |
Contributor
Author
|
Next thing I will do after this PR is merged, I will start to remove subprocesses and replace them by native Python utils. I'll also try to fix status bar. |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #183. To make @Hog185 and @Splayer0 happy, I'll just go and explain how this works :D
So, I made a small worker that starts before PKEXEC, logs XDG_DOWNLOAD_DIR (or ~/ if XDG_DOWNLOAD_DIR doesn't exist) to a variable, passes it to the app running as root before exiting in nanoseconds.
The file manager from the GUI automatically takes the content of the variable as default directory.
Made sure utils.py doesn't erase the variable.
I also made tests (including edge cases), ruff-formatted and tested.
No AI used.
All of the commits before 459502e were deleted, so don't worry about them.
And in 00b2c94's commit message, I meant @Splayer0.