This repository was archived by the owner on Nov 28, 2022. It is now read-only.
Changes for Sidechains Integration Step 2#153
Open
ptagl wants to merge 494 commits into
Open
Conversation
…data_hash optional in py tests
Fixed a bug that was preventing the ban of nodes sending an invalid proof for certificates or CSW transactions. Added a flag to force the ban of misbehaving local nodes when running in regression test.
…gration_step4 branch; a variant of the UT logic with lower impact on code base has been imported as well
Added a new Python test to check that CSW transactions in mempool are rejected in case the sidechain passes from "ceased" to "alive" (due to a chain fork and the disconnection of the ceasing block). Removed some unused code and variables from sc_cert_memcleanup_split.py.
…nsaction; this will be superseeded with the fix for issue #95
…cmd send_certificate
…sw proofs; this test is not included in the regression list since can be very time consuming
…with priority + segment size and num constraints to pass to test functions
Ported fix related to p2p mempool msg from PR107 into sidechains_inte…
Fixed the compilation errors caused by the changes to the MC Crypto Lib. Added a unit test to check that the pointer returned by the batch verifier is freed correctly (Valgrind required).
…dechains_integration_step4
Proves -> Proofs
When running the "sc_cert_memcleanup_split.py" test, some error strings were printed suggesting a possible issue with the management of the MBTR outputs in mempool. This has been fixed since now a MBTR output created in a specific epoch is still valid during next epochs (as opposed to the previous behavior).
…ll SCs and using a higher complexity for proof generation
…to sc_big_block test
…first round - build ok
…second round, modifications for UT and py test regression tests OK
Fixed the compilation and test errors due to the introduction of the sidechain ID as mandatory parameter for the generation of certificate proofs.
…sidechains_integration_step4
* remove unused arm64 dockerfiles * replace ubuntu:xenial with ubuntu:focal * update gosu to 1.13
prep sc testnet2 part1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request brings the following changes:
SidechainIdas a public input for the certificate proofs. Sidechains integration step4 cert sc id #134constantfor certificate proofs has been made optional. Make argument constant as optional in proof generation. #143-disablewalletflag. Added check of wallet ptr before using it, that prevents unwanted der… #141send_certificateRCP command. Cert submitter optimization #116