[crash] Crash when scanning Native Instruments plugins for plugin node

[JaredIsrael]

Crash details

Diagnostic info

Application: Splitwave
Version: 1.1.0
Architecture: ARM-64 (native)
macOS: 14.6.1 (23G93)
Crash type: EXC_BREAKPOINT (SIGTRAP)
Crashed thread: tokio-rt-worker

Crashed Thread

Thread 20 Crashed:: tokio-rt-worker
0   libdispatch.dylib    _dispatch_assert_queue_fail + 120
1   libdispatch.dylib    dispatch_assert_queue + 196
2   HIToolbox             islGetInputSourceListWithAdditions + 160
3   HIToolbox             isValidateInputSourceRef + 92
4   HIToolbox             TSMGetInputSourcePropertyWithSetter + 48
5   Choral                NI_6_5_3_R5::QCocoaInputContext::updateLocale() + 48
6   Choral                NI_6_5_3_R5::QCocoaInputContext::QCocoaInputContext() + 248
7   Choral                NI_6_5_3_R5::QCocoaIntegration::QCocoaIntegration(...) + 1112
8   Choral                NI_6_5_3_R5::QCocoaIntegrationPlugin::create(...) + 88
9   Choral                NI_6_5_3_R5::QPlatformIntegrationFactory::create(...) + 188
10  Choral                NI_6_5_3_R5::init_platform(...) + 1732
11  Choral                NI_6_5_3_R5::QGuiApplicationPrivate::createPlatformIntegration() + 1492
12  Choral                NI_6_5_3_R5::QGuiApplicationPrivate::createEventDispatcher() + 36
13  Choral                NI_6_5_3_R5::QCoreApplicationPrivate::init() + 1656
14  Choral                NI_6_5_3_R5::QGuiApplicationPrivate::init() + 68
15  Choral                NI_6_5_3_R5::QApplicationPrivate::init() + 36
16  Choral                NI_6_5_3_R5::QApplication::QApplication(...) + 140
17  Choral                ni::qt::Module::Module(...) + 212
18  Choral                ModuleStartup::startup() + 116
19  splitwave             Vst3Module::open + 684
20  splitwave             Vst3Backend::scan_bundle + 64
21  splitwave             Vst3Backend::scan + 168
22  splitwave             PluginBackend::scan_all + 120
23  splitwave             scan_all + 120

Relevant Plugin

Choral.vst3
Version: 1.3.3 (R22)
Developer: Native Instruments GmbH
Format: VST3

Steps to reproduce

1. Create new pipeline
2. Add 'plugin' node (to initiate plugin scanning)

Expected behavior

Expected list of plugins to load

Additional context

Looks like this is coming from initialization of NI plugins when scanning, This thread was failing on 'Choral' from NI, but I uninstalled that plugin and then retried and the same crash happpened but for 'Driver' from NI. Other plugins, for example soundtoys, appear to have loaded fine before this when looking at the full stack trace in the crash report. I've trimmed it to just the crashed thread but let me know if you want any other information. This bug means I can't use the 'plugin' node at all which is pretty restrictive. Note that I didn't see any button or prompt to create a github bug report from the app after the crashes.

[Horuse]

Thank you for the detailed crash report and stack trace -they were very helpful in tracking this down.

This also turned out to be related to some of the lifecycle and thread-affinity issues investigated in #35.

I’m currently working on and testing the fix across the supported plugin formats. This issue should be resolved in the next Splitwave release

[Horuse]

I recently released v1.2.0 (due to an issue with updating the app in v1.1.0 (#45), you’ll unfortunately need to download this version manually). I’d be very grateful if you could let me know whether the problem has been resolved in your environment.

[JaredIsrael]

Hi there, just downloaded the latest version and the issue is fixed! There is a bit of a stutter when adding the plugin node, but I have a tremendous amount of plugins, and from the description of the issue it sounds like multi threading was causing some of the issue so this seems like a compromise. I have also found two really small bugs while using the feature and have made two new issues, but they are both low priority IMO and don't impact usability much:

• [bug] Plugin editor window does not resize properly on macOS · Issue #48 · Horuse/Splitwave
• [bug] Parameters of certain VST3 plugins are listed as binary rather than floating point in plugin node · Issue #49 · Horuse/Splitwave

Thanks a bunch for fixing this! This app/feature simplifies some of my audio solutions tremendously and it being open source with responsive development is amazing 😄