ci: check linux and windows in addition to macos - #30
Merged
Merged
Conversation
Matrix the check job across macOS, Ubuntu 22.04 and Windows. Linux gets the PipeWire + GTK system deps the backend needs to compile; Windows gets the CMake 4.x policy override for audiopus_sys. Windows WASAPI code stays covered by the per-OS cfg gates on every PR instead of only at release.
Linux smoke tests need a live PipeWire daemon and the runner has none, so the step boots one before cargo test. playback_pulls_samples hardcodes a real ALSA device and cannot pass without hardware, so it is skipped there. The Windows test binary cannot start because tauri embeds its Common-Controls v6 manifest into the app binary only, not test harnesses (tauri#13419), so Windows compiles with --no-run and tests run on macOS and Linux.
ts-rs emits the exported enum per platform, so cfg-gating the Au variant on
macOS made the committed PluginFormat.ts ("clap" | "au" | "vst3") diverge
from what Linux and Windows generate, failing the TS-RS bindings check.
The format is data that the UI already expects everywhere; only the AU
backend is macOS-only, so gate that instead and make the host dispatch
panic for Au on non-macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The check job in CI runs only on macOS, so every PR leaves the Linux
(PipeWire) and Windows (WASAPI) backends unverified until release time.
This matrices the job across all three platforms so the per-OS cfg gates
actually get compiled on every PR.
Why is this the right approach?
A matrix is the standard pattern used by tauri-apps and cpal themselves:
one workflow, three runners, no duplicated steps. Linux needs its native
headers installed explicitly (PipeWire + GTK, same set as the release
workflow), while macOS and Windows runners ship their SDKs preinstalled.
Windows would fail without CMAKE_POLICY_VERSION_MINIMUM: '3.5' because
CMake 4.x rejects audiopus_sys's ancient policy version — that override is
already set in src-tauri/.cargo/config.toml for local builds, and this
mirrors it in CI. No new dependencies.
Checklist
bun run checkpassescargo check --manifest-path src-tauri/Cargo.tomlpassesbun run formatleaves the tree cleanchange adds no allocations, locks, or syscalls to cpal / SCK callbacks
or
DspWorker::run