fix: keep drop preview tracking when scrolling mid-drag - #18
Merged
Merged
Conversation
Re-resolve the drop preview against the last pointer position on scroll, and listen on nested data-dnd-scroll viewports so virtualized lists are covered. Closes #17
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17.
Scrolling mid-drag left the drop preview stale and made dropping impossible.
Changes
DndController.recomputeDropPreview()re-resolves the preview against the last known pointer position; the droppable scroll handler calls it after refreshing zones, so the preview keeps tracking under a stationary cursor.[data-dnd-scroll]viewports, so virtualized lists (virtua) whose scroll viewport is a descendant are covered. Scroll events do not bubble, hence the direct listener.Tests
tests/entities/droppable-scroll.test.tscovering own-element scroll, nesteddata-dnd-scrollviewport, and listener cleanup after drag end.