fix: macOS Tahoe compatibility#2
Open
spro wants to merge 1 commit into
Open
Conversation
…ility SwiftUICore was deprecated and causes compilation errors in macOS Tahoe. Updated to use the standard SwiftUI import instead.
nathanbirrell
approved these changes
Apr 7, 2026
MegaManSec
referenced
this pull request
in MegaManSec/magic-switch
May 28, 2026
…ret pairing Replace the unauthenticated plaintext TCP control channel with a sealed channel keyed by a 9-character pairing code that the user shares between their two Macs out of band. The pairing code is stretched via PBKDF2-HMAC-SHA256 (600k iterations) and stored in the Keychain; each connection negotiates per-direction session keys via HKDF over fresh 32-byte nonces, then frames messages with ChaCha20-Poly1305 (4-byte length, 12-byte counter nonce, ciphertext, tag) capped at 64 KiB per frame. The first sealed message must be the literal AUTH_OK; failure counts toward a per-IP rate limit (5 failures / 60s -> 15 min block). Per-connection state replaces the previously shared ConnectionManager instance, closing the racy-lastReceivedCommand hijack. A 30s idle timer and 5-minute total budget per connection close slow-drip attacks. SettingsView gains a Pairing tab that drives generate/enter/unpair and shows a SHA256(K)[0..4] fingerprint for visual verification. Outbound calls (executeCommand, sendNotification, sendPeripheralSync) now route through OutgoingConnection and fail closed if unpaired. BluetoothPeripheralStore.updatePeripherals additionally rejects lists larger than 64 entries. Addresses bugs #1, #2, #3, #4, #5 from the security review.
github-actions Bot
referenced
this pull request
in MegaManSec/magic-switch
May 28, 2026
# 1.0.0 (2026-05-28) ### Bug Fixes * **model:** validate decoded peripheral MAC and clamp name length ([54fcae5](54fcae5)) ### Features * initial commit ([872a902](872a902)) * **menubar:** adapt status bar icon to dark and light mode ([14f7639](14f7639)), closes [#1](#1) * **network:** authenticate and encrypt peer protocol with shared-secret pairing ([a5dbf48](a5dbf48)), closes [#1](#1) [#2](#2) [#3](#3) [#4](#4) [#5](#5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwiftUICore was deprecated and causes compilation errors in macOS Tahoe. Updated to use the standard SwiftUI import instead.