Add convert-png-jpeg CLI task to convert non-transparent PNGs to JPEG in-place#1526
Open
naaaaaaaaaaaf wants to merge 1 commit into
Open
Add convert-png-jpeg CLI task to convert non-transparent PNGs to JPEG in-place#1526naaaaaaaaaaaf wants to merge 1 commit into
convert-png-jpeg CLI task to convert non-transparent PNGs to JPEG in-place#1526naaaaaaaaaaaf wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
--limitand--min-idoptions and a--dry-runpreview mode.Description
convert-png-jpegunderMastodon::CLI::mediawith options--limit,--min-id, and--dry-runand documentation inlong_desc.MediaAttachmentrecords withfile_file_nameending in.png, optionally resumes frommin_idand limits the number processed withlimit.Vips::Imageto detect an alpha channel and skips transparent images, converts non-transparent images to JPEG (Q: 85) into aTempfile, and assigns the tempfile to the attachment while updating file metadata before saving.Vips::Errorto log processing errors.Testing
bundle exec rspec, and the test suite passed.Codex Task