Skip to content

Minor fixes on loading model from config, updated config example to include name #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HotNoob merged 3 commits into from
Aug 31, 2025
Merged

Minor fixes on loading model from config, updated config example to include name #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1218a6f
Fix missing device_model assignment from config
Potoonite Aug 31, 2025
c546fb4
Detect and handle absolute path for config file
Potoonite Aug 31, 2025
a4ae7d3
Add the field name to config example. MQTT uses it.
Potoonite Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions classes/transports/transport_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ def __init__(self, settings : "SectionProxy") -> None:
if settings:
self.device_serial_number = settings.get(["device_serial_number", "serial_number"], self.device_serial_number)
self.device_manufacturer = settings.get(["device_manufacturer", "manufacturer"], self.device_manufacturer)
self.device_model = settings.get(["device_model", "model"], self.device_model)
self.device_name = settings.get(["device_name", "name"], fallback=self.device_manufacturer+"_"+self.device_serial_number)
self.bridge = settings.get("bridge", self.bridge)
self.read_interval = settings.getfloat("read_interval", self.read_interval)
Expand Down
1 change: 1 addition & 0 deletions config.cfg.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ bridge = transport.1
# Device identity (for MQTT topic structure or HA discovery)
manufacturer = HDHK
model = HDHK 16CH AC
name = HDHK 1
# Optional; auto-detect if omitted
serial_number = HDHK777

Expand Down
7 changes: 6 additions & 1 deletion protocol_gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,12 @@ def __init__(self, config_file : str):
self.__log.addHandler(handler)

self.config_file = os.path.dirname(os.path.realpath(__file__)) + "/growatt2mqtt.cfg"
newcfg = os.path.dirname(os.path.realpath(__file__)) + "/"+ config_file
if config_file:
if os.path.isabs(config_file):
newcfg = config_file
else:
newcfg = os.path.dirname(os.path.realpath(__file__)) + "/" + config_file

if os.path.isfile(newcfg):
self.config_file = newcfg

Expand Down