Conversation
* Finalize first try at implementation with tilt * Example runs with zero tilt * Debug plotting with tilt * Finish testing curled wake model * Update dependencies * Add back in factor of D * Add tests for rotor differences * Changed tests * Finish tests and put back in kirby rotor code * Update gaussian smoothing to account for tilt * Update UMM compatibility * Update UMM and MITRotor packages * Update package version * Sg/tilted bem dev (#32) * Update BEM rotor to allow for tilt input * Update plotting to allow any slice * Add new yaw and tilt example * Debugging new tilt example * Finish debugging MITWindFarm yaw/tilt * Add in optimization timing * Add in timing * Rename example file * Example cleanup for PR * New example with yaw and tilt comparisons added * Clean up pre-merge * Final example cleanup * Finalize examples * Clean up unneeded calls to super
Contributor
Author
|
This was all already discussed over in #31. We are now ready to merge into main! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You're making a pull request to a branch (probably main) of MITWindFarm. Please ensure you have done the following.
If you want more details on best practices, please see the following guide on the Howland Lab Google Drive.
Happy merging!