Add dummy controller for primary simulation#12
Open
karimali5 wants to merge 77 commits intoigridSGS-KSHfrom
Open
Add dummy controller for primary simulation#12karimali5 wants to merge 77 commits intoigridSGS-KSHfrom
karimali5 wants to merge 77 commits intoigridSGS-KSHfrom
Conversation
GNU AMD KA
Rebase to latest igridSGS-KSH
Rebase to igridSGS-KSH
…t to avoid deadlock that occasionally happens
…o is very high by design
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in here
When wind-angle controller is activated for both the precursor and the primary simulations, the controller action for the primary starts to strongly oscillate leading to strong pressure oscillations which contaminate the solution.
For example in the below figure, the blue markers show the control action of the primary simulation when it has its own independent controller versus that of the precursor simulation (black). The control action of the primary simulation oscillates between the controller trigger (around 0.1) and ~15 degrees.
This behavior leads to nonphysical velocities as indicated by the hub-height slice of the normalized streamwise velocity ($u/G$ ).
The solution here is to introduce the flag 'dummy_controller' (true or false) in the &CONTROL namelist. When activated for the primary simulation, a dummy wind-angle controller is created which points to the controller of the precursor simulation.
When the controller action is being calculated (in 'update_RHS_control' being called from 'popRHS_stuff.F90'), the dummy controller mimics the action of the precursor controller and applies this action to the primary flow field rather than calculating its own action based on the primary flow field.
The resulting control action and wind-speed field are shown above labeled 'dummy controller'.