Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the export utilities to support creating file lists for tarball generation and fixes bugs in BudgetIO helper functions.
Key changes:
- Extracts file listing logic into a new
list_padeops_files()function that returns file paths instead of copying them - Adds
print_files_stdout()function for command-line usage with tar - Implements the previously stubbed
export_concurrent()function with basic command-line argument handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| padeopsIO/utils/export.py | Refactors copy_padeops_data to extract file listing logic into list_padeops_files, adds print_files_stdout helper, and implements basic CLI for export_concurrent |
| padeopsIO/budgetIO.py | Adds query_logfile method, fixes parameter name in get_ustar call (from search_str to logfile), and updates documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to
utils/export.pyto return a list of files to export (say, in a tarball)Small bug fixes to
BudgetIO.get_ustar()and other helper functions.