Lösung Jonas Render #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+9
to
+20
| @Test | ||
| @DisplayName("Test 1 MadLib") | ||
| void createSentence () throws Exception { | ||
| MadLib sentence = new MadLib(); | ||
|
|
||
| String s = sentence.create(); | ||
|
|
||
| if (s != null && s.startsWith("Java programming is so")) { | ||
| } else { | ||
| throw new Exception("Sentence is null or not starting correctly."); | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Bei Unit-Tests brauchen wir immer mind. ein assert-Statement, damit es ein "echter" Unit Test ist, also z. B. sowas hier:
@DisplayName("should return a random sentence about java")
void test1() {
// when
var result = underTest.create();
// then
assertNotNull(result);
assertTrue(result.startsWith("Java programming is so"));
}
@Test
@DisplayName("should contain the random adjectives, verbs and famous persons")
void test2() {
// when
var result = underTest.create();
// then
assertTrue(contains(result, MadLib.ADJECTIVES));
assertTrue(contains(result, MadLib.VERBS));
assertTrue(contains(result, MadLib.FAMOUS_PERSONS));
}
private boolean contains(String value, String[] wordList) {
for (String word : wordList) {
if (value.contains(word)) {
return true;
}
}
return false;
}
Comment on lines
+23
to
33
| public static String[] getADJECTIVES() { | ||
| return ADJECTIVES; | ||
| } | ||
|
|
||
| public static String[] getVERBS() { | ||
| return VERBS; | ||
| } | ||
|
|
||
| return ""; // TODO: this is only here so that the code can be compiled, please replace it with your result | ||
| public static String[] getFamousPersons() { | ||
| return FAMOUS_PERSONS; | ||
| } |
Owner
There was a problem hiding this comment.
Die getter-Methoden auf die static Arrays sind nicht zwingend notwendig. Du nutzt sie z. B. auch gar nicht.
Man sollte immer nach dem YAGNI (You ain't gonna need id) Konzept programmieren. Wenn du etwas nicht nutzt, dann programmiere es nicht.
Comment on lines
11
to
+21
| public String create() { | ||
| // TODO: implement this method | ||
| Random randomNumber = new Random(); | ||
|
|
||
| int randomAdjective = randomNumber.nextInt(ADJECTIVES.length); | ||
| int randomVerb = randomNumber.nextInt(VERBS.length); | ||
| int otherRandomVerb = randomNumber.nextInt(VERBS.length); | ||
| int randomFamousPerson = randomNumber.nextInt(VERBS.length); | ||
|
|
||
| return "Java programming is so " + ADJECTIVES[randomAdjective] + "! It makes me so excited all the time because I love to " + VERBS[randomVerb] + ". Stay hydrated and " + VERBS[otherRandomVerb] +" like you are " + FAMOUS_PERSONS[randomFamousPerson]+"!"; | ||
| } |
Owner
There was a problem hiding this comment.
Das passt soweit. Das hier ist die Musterlösung:
public String create() {
String randomAdjective = randomChoice(ADJECTIVES);
String randomVerb1 = randomChoice(VERBS);
String randomVerb2 = randomChoice(VERBS);
String randomFamousPerson = randomChoice(FAMOUS_PERSONS);
return String.format(
"Java programming is so %s! It makes me so excited all the time because I love to %s. Stay hydrated and %s like you are %s!",
randomAdjective,
randomVerb1,
randomVerb2,
randomFamousPerson
);
}
private String randomChoice(String[] wordList) {
return wordList[random.nextInt(wordList.length)];
}Mit String.format() kann man ein String ohne die ganzen " + " zusammenbauen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
kannst du dir meine Lösung mal anschauen und mir dazu Feedback geben? Danke!