Test/add high risk flow coverage#63
Merged
Naomi-Gift merged 3 commits intoJun 2, 2026
Merged
Conversation
- Regenerated pnpm lockfile with proper native dependency resolution - Added @rolldown/binding-win32-x64-msvc for Vitest build tools - npm test now runs successfully (32 tests passing) - Updated README with Node.js version requirements (18+ LTS) - Added pnpm installation guidance and native dependency handling docs - All 4 test files passing with Vitest v4.1.8
…rvice High-Risk Flow Tests: - Add Discover page tests covering loading, results, empty state, filtering, and pagination - Add Submit page tests verifying wallet gating and form validation - Add Admin page tests verifying authorization and request management - Add Review service tests with success/error paths - Add Soroban service tests with mocks for wallet/RPC behavior - Add Wallet service tests covering connection and transaction signing Verification Service Implementation: - Create persistent VerificationService with localStorage backing - Submit requests return tracking ID and PENDING status - GetVerificationStatus returns actual status, not mock values - Admin approve/reject updates persisted state - Admin can distinguish between no request (NONE) vs rejected (REJECTED) - Track request history with submission/update timestamps and user info - Prevent duplicate pending requests - Support resubmission after rejection via reset - Provide admin statistics and pending request list Service Integration: - Update soroban.service to delegate verification to new service - Remove hardcoded parseInt(projectId, 36) % 3 mock logic - Maintain backward compatibility with error handling Tests: - Verification service: 28 tests passing - Service mocks wallet/RPC interactions properly - Clear distinction between NONE/PENDING/VERIFIED/REJECTED states
|
@Prz-droid Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #54
close #50