Claude/release readiness audit q7 ux c#13
Merged
Conversation
…ackend safety P0 fixes: - Fix dict mutation in consensus.py, voting.py, conflicts.py: copy backend_kwargs instead of aliasing, matching synthesize.py pattern - Fix budget off-by-one: record() now uses >= to match exhausted property, consistently enforcing the boundary - Fix JSON extraction: _try_extract_object now tracks string literals so braces inside JSON string values don't break brace matching P1 fixes: - Ollama backend: catch ValueError from response.json() and raise a clear RuntimeError instead of opaque JSONDecodeError - OpenAI backend: explicitly pass stream=False, fix operator precedence in response handling to guard against None message Tests: - Add budget exact-boundary test - Add backend_kwargs mutation tests for consensus and voting - Add JSON parsing tests for braces inside string values https://claude.ai/code/session_01H1AP8Drr8SE7QFevAookwL
The validator treated recommended_n > 10 as a validation error with the text "Are you sure?" — which blocked legitimate task files while using language that suggested it should be a soft warning. Changed to emit a warnings.warn() instead, matching scatter.py's pattern for high n values. https://claude.ai/code/session_01H1AP8Drr8SE7QFevAookwL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the change in a few sentences.
Checklist
make release-checkpasses locallyNotes
Add any reviewer context, risks, or follow-up items here.