Skip to content

Sync content-type for small s3 objects. #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DailyDreaming wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Sync content-type for small s3 objects. #2626

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9f551f
Sync metadata for small s3 objects.
DailyDreaming Nov 24, 2019
fcb2e4d
Update implementation.py
DailyDreaming Nov 24, 2019
ddc8f04
Update implementation.py
DailyDreaming Nov 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dss/stepfunctions/s3copyclient/implementation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,12 @@ def setup_copy_task(event, lambda_context):
event[_Key.UPLOAD_ID] = mpu['UploadId']
event[Key.FINISHED] = False
else:
s3_blobstore.copy(source_bucket, source_key, destination_bucket, destination_key)
s3_blobstore.copy(source_bucket,
source_key,
destination_bucket,
destination_key,
# TODO: change to "content_type" to be consistent with cloud_blobstore syntax?
ContentType=blobinfo['ContentType'])
event[_Key.UPLOAD_ID] = None
event[Key.FINISHED] = True
event[Key.CONTENT_TYPE] = blobinfo['ContentType']
Expand Down