Repository navigation
Conversation
One registration call is limited to 10 seconds, and each heartbeat and the events stream, including body reads, are limited to the session TTL, so a stalled control connection fails into the existing backoff and re-register path. An events stream that reaches that deadline while the session is still live is renewed, and failures that continue past the TTL end the session. After a session is canceled, both control loops are drained before the next session starts, and a canceled parent context stops the loops as shutdown. A unit test withholds the heartbeat response until the attempt context ends and requires the loop to report session loss. Fixes HyNetworks#1637
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One registration call is limited to 10 seconds, and each heartbeat and the events stream, including body reads, are limited to the session TTL, so a stalled control connection fails into the existing backoff and re-register path. An events stream that reaches that deadline while the session is still live is renewed, and failures that continue past the TTL end the session. After the WAN address changes, a realm server that is still running leaves its previous public endpoint registered with the coordination server. Clients can still resolve the realm, then time out against that endpoint until the process is restarted and registration runs again.
Gofmt reports the edited server files as already formatted. go vet ./cmd/... reports no issues.
Closes #1637