Skip to content

Add pyproject.toml#11

Open
mwilensky768 wants to merge 8 commits intomainfrom
pyproject
Open

Add pyproject.toml#11
mwilensky768 wants to merge 8 commits intomainfrom
pyproject

Conversation

@mwilensky768
Copy link
Copy Markdown
Contributor

I thought adding a pyproject.toml would make installation a little more automated. In theory users should just be able to type pip install . within an environment and it should install (maybe they need python -m pip install . depending on how their computer is set up).

I haven't tested it yet but though I would make the PR anyway to get some visibility.

I noticed we don't have a license yet -- not strictly necessary since no one is asking us to use the code AFAIK who isn't on the team but wanted to call attention to it in case it mattered.

@mwilensky768 mwilensky768 requested a review from philbull July 8, 2025 22:42
Copy link
Copy Markdown
Member

@philbull philbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor changes needed

Comment thread pyproject.toml
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
spherical,
hera_sim,
]
requires-python = ">=3.10"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py3.10 now dropped; py3.11 is the minimum

Comment thread pyproject.toml
Comment thread pyproject.toml Outdated
@mwilensky768
Copy link
Copy Markdown
Contributor Author

Thanks @philbull I think I got everything.

@mwilensky768
Copy link
Copy Markdown
Contributor Author

mwilensky768 commented Oct 29, 2025

@philbull I fixed some merge conflicts

@mwilensky768
Copy link
Copy Markdown
Contributor Author

@philbull is this stale? Do we want it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants