Conversation
…tarting positions, and saving some outputs
…on -- status: still works
This reverts commit a6a6080.
Contributor
Author
|
Hi @philbull I just refactored beam_example into four new files: I think this is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a lot of changes to beam_example.py and related code to make it so that power beam sampling can be done.
Additionally, it adds some compatibility for more up-to-date pyuvdata and matvis versions. I also think we should switch to numpy>2 -- the only relevant update is the np.random API as far as I understand.
@philbull I'm requesting your review for vis_simulator.py
In particular, I've done some changes to follow pyuvdata's UVBeam/AnalyticBeam/BeamInterface stuff and I'm not sure if I made the relevant update everywhere in the code (in other words I fixed functions that I used during beam sampling but other simulator functions might need to follow up and I think you have a better knowledge of where these lines exist).