Ss brake clean - #102
Open
Knhwong wants to merge 4 commits into
Open
Conversation
added 3 commits
March 6, 2023 18:45
maxguy2001
requested changes
Mar 20, 2023
TomLonergan03
requested changes
Mar 20, 2023
TomLonergan03
approved these changes
Mar 20, 2023
maxguy2001
requested changes
Mar 20, 2023
| void release(); | ||
|
|
||
| private: | ||
| const std::uint8_t pin_; |
Member
There was a problem hiding this comment.
It's explicitly used in constructor for writer but nowhere else?
| class Brakes { | ||
| public: | ||
| Brakes(const std::uint8_t pin, const io::IGpio gpio); | ||
| void stop(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as brake, makes things cleaner.