Skip to content

SNS - IMD - #110

Open
sa-fx wants to merge 11 commits into
masterfrom
sns-imd
Open

SNS - IMD#110
sa-fx wants to merge 11 commits into
masterfrom
sns-imd

Conversation

@sa-fx

@sa-fx sa-fx commented Mar 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

IMD requirements

  • Retrieve the isolation status from the IMD
  • Retrieve real-time values for resistance between the positive power supply terminal and the chassis, and the negative power supply terminal and the chassis

@sa-fx sa-fx added the sensors Sensors Project label Mar 27, 2023
@sa-fx sa-fx self-assigned this Mar 27, 2023
maxguy2001
maxguy2001 requested changes Mar 29, 2023
View reviewed changes
Comment thread lib/debug/repl.cpp Outdated
Comment thread test/core/CMakeLists.txt Outdated
TomLonergan03
TomLonergan03 requested changes May 29, 2023
View reviewed changes

@TomLonergan03 TomLonergan03 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should get it to build once you fix these issues, my bad on the can.hpp id type

Comment thread lib/sensors/imd_processor.cpp Outdated
Comment thread lib/sensors/imd.cpp Outdated
Comment thread lib/sensors/imd.hpp Outdated
Comment thread lib/sensors/imd.hpp
Comment thread lib/sensors/imd.cpp Outdated
Comment thread lib/sensors/imd.hpp Outdated
@sa-fx
sa-fx marked this pull request as ready for review May 29, 2023 20:06
@sa-fx
sa-fx requested review from ishmis and kshxtij as code owners May 29, 2023 20:06
TomLonergan03
TomLonergan03 requested changes May 29, 2023
View reviewed changes

@TomLonergan03 TomLonergan03 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 more things then good to go

Comment thread lib/debug/repl.hpp
Comment thread lib/sensors/imd.hpp Outdated
@sa-fx
sa-fx requested a review from maxguy2001 May 30, 2023 08:07
maxguy2001
maxguy2001 requested changes May 30, 2023
View reviewed changes
Comment thread lib/sensors/imd.hpp
Comment thread lib/sensors/imd.cpp Outdated
Comment thread lib/sensors/imd.cpp Outdated
@sa-fx
sa-fx requested a review from maxguy2001 May 30, 2023 20:56
@sa-fx sa-fx removed their assignment May 30, 2023
maxguy2001
maxguy2001 requested changes May 30, 2023
View reviewed changes

@maxguy2001 maxguy2001 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny style guide thing but otherwise good to go

Comment thread lib/sensors/imd.cpp Outdated
@sa-fx
sa-fx requested a review from maxguy2001 May 31, 2023 08:37
ishmis
ishmis approved these changes May 31, 2023
View reviewed changes

@ishmis ishmis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes, otherwise hope it gets tested

Comment thread lib/debug/repl.cpp
Comment thread lib/debug/repl.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomLonergan03 TomLonergan03 TomLonergan03 approved these changes
@maxguy2001 maxguy2001 maxguy2001 approved these changes
@ishmis ishmis ishmis approved these changes
@kshxtij kshxtij Awaiting requested review from kshxtij kshxtij is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

sensors Sensors Project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sa-fx @TomLonergan03 @maxguy2001 @ishmis