Nav - Wheel Encoder Preprocessing - #38
Merged
Merged
Conversation
maxguy2001
requested changes
Nov 8, 2022
maxguy2001
reviewed
Nov 8, 2022
maxguy2001
requested changes
Nov 10, 2022
maxguy2001
reviewed
Nov 10, 2022
maxguy2001
requested changes
Nov 11, 2022
maxguy2001
requested changes
Nov 15, 2022
maxguy2001
left a comment
maxguy2001
left a comment
Member
There was a problem hiding this comment.
A few further changes for now. I think we need to look at using templates and removing repetitive code with helper functions here but good progress.
maxguy2001
requested changes
Nov 28, 2022
maxguy2001
requested changes
Nov 28, 2022
maxguy2001
requested changes
Nov 28, 2022
maxguy2001
requested changes
Nov 30, 2022
maxguy2001
left a comment
maxguy2001
left a comment
Member
There was a problem hiding this comment.
Good progress! Not quite ready to be converted from draft but starting to look good!
maxguy2001
reviewed
Jan 18, 2023
BenET01
reviewed
Feb 9, 2023
ishmis
requested changes
Feb 9, 2023
TomLonergan03
requested changes
Feb 10, 2023
TomLonergan03
approved these changes
Mar 7, 2023
TomLonergan03
left a comment
TomLonergan03
left a comment
Contributor
There was a problem hiding this comment.
i'm happy with this
maxguy2001
requested changes
Mar 8, 2023
ishmis
requested changes
Mar 13, 2023
ishmis
approved these changes
Mar 16, 2023
ishmis
left a comment
ishmis
left a comment
Contributor
There was a problem hiding this comment.
smol changes, but all g if addressed
maxguy2001
approved these changes
Mar 20, 2023
kshxtij
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implementing preprocessing of encoder's data