Skip to content

sns-pressure sensor - #96

Open
Platiniom64 wants to merge 4 commits into
masterfrom
sns-pressure
Open

sns-pressure sensor#96
Platiniom64 wants to merge 4 commits into
masterfrom
sns-pressure

Conversation

@Platiniom64

Copy link
Copy Markdown
Contributor

WIP, still have to test it once we receive the sensory

@Platiniom64
Platiniom64 requested a review from ishmis as a code owner February 16, 2023 18:33
Comment thread lib/sensors/pressure.hpp Outdated
Comment thread lib/sensors/pressure.hpp Outdated
Comment thread lib/sensors/pressure.cpp Outdated
Comment thread lib/sensors/pressure.hpp
Comment thread lib/sensors/pressure.hpp Outdated
Vladimir Hanin added 2 commits February 21, 2023 20:14
Vladimir Hanin
yes
Merge branch 'master' into sns-pressure

@ishmis ishmis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor things, functionally not much to say

Comment thread lib/sensors/pressure.cpp Outdated
Comment thread lib/sensors/pressure.cpp Outdated
Comment thread lib/sensors/pressure.cpp
Comment thread lib/sensors/pressure.hpp
Comment thread lib/sensors/pressure.hpp Outdated
Comment thread lib/sensors/pressure.hpp
#include <memory>
#include <optional>

#include <core/logger.hpp>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing core/types.hpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants