SNS - Brakes sensor - #72
Open
tahn1234 wants to merge 14 commits into
Open
Conversation
Contributor
|
Make modifications so that it build and push. |
added 4 commits
February 26, 2024 19:27
added 3 commits
March 4, 2024 18:32
TomLonergan03
requested changes
Mar 7, 2024
added 3 commits
March 18, 2024 18:50
davidbeechey
requested changes
Mar 19, 2024
| if (!optional_reading) { return std::nullopt; } | ||
| const auto reading = *optional_reading; | ||
|
|
||
| if (reading == core::DigitalSignal::kHigh) { return false; } |
Contributor
There was a problem hiding this comment.
You don't need an if statement here - you can just return the condition :)
| Brakes::Brakes(core::ILogger &logger, std::shared_ptr<io::IGpioReader> gpio_reader) | ||
| : gpio_reader_(gpio_reader), | ||
| logger_(logger), | ||
| pin_() |
Contributor
There was a problem hiding this comment.
Do you need this here? Either pass the pin into the constructor if it may need to be accessible in the future (i.e. if something else might want to know which pin it's using) or remove it from here and the header file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.