SNS - LED Driver - #27
Open
siny-over-cosy wants to merge 54 commits into
Open
Conversation
siny-over-cosy
requested review from
H-Allen and
licornes-fluos
as code owners
October 14, 2024 17:48
merge main to my branch
davidbeechey
left a comment
davidbeechey
left a comment
Collaborator
There was a problem hiding this comment.
Good start! A few wee things to fix. Would be good to add a description + link to the datasheet in the PR description, Linear issue description and as a Rust doc comment (using ///) for LedDriver
Co-authored-by: Kshitij Sharma <kshitij4sharma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.