Skip to content

Fix CI failures: lint warning, coverage gaps, and security audit#2

Merged
dineshkn-dev merged 4 commits intomainfrom
copilot/fix-test-cases
Feb 6, 2026
Merged

Fix CI failures: lint warning, coverage gaps, and security audit#2
dineshkn-dev merged 4 commits intomainfrom
copilot/fix-test-cases

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 6, 2026

CI was failing on three checks: ESLint warning, coverage thresholds not met (98.03% statements vs 99% required, 94.92% branches vs 95% required, 98.5% functions vs 100% required), and security audit.

Changes

  • Lint: Removed unused Platform import from SearchBar.tsx

  • Coverage: Added missing tests for storage layer edge cases

    • secureStore.ts: Memory store fallback for deleteItem
    • vaultStorage.ts: Key management functions (getOrCreateVaultKey, getVaultKey, deleteVaultKey) and export validation (empty passphrase, empty blob content, iOS iterations)
  • Security: Updated @isaacs/brace-expansion to patch high-severity vulnerability

Coverage Results

All files          |   99.84 |    97.14 |     100 |   99.84
 storage           |     100 |      100 |     100 |     100
  secureStore.ts   |     100 |      100 |     100 |     100
  vaultStorage.ts  |     100 |      100 |     100 |     100

196 tests passing (8 new test cases added).

Original prompt

Fix the test cases.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: dineshkn-dev <16734918+dineshkn-dev@users.noreply.github.com>
@dineshkn-dev dineshkn-dev requested a review from Copilot February 6, 2026 19:58
Co-authored-by: dineshkn-dev <16734918+dineshkn-dev@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: dineshkn-dev <16734918+dineshkn-dev@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the test cases for improved reliability Fix CI failures: lint warning, coverage gaps, and security audit Feb 6, 2026
Copilot AI requested a review from dineshkn-dev February 6, 2026 20:02
@dineshkn-dev dineshkn-dev marked this pull request as ready for review February 6, 2026 20:03
@dineshkn-dev dineshkn-dev merged commit d66220c into main Feb 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants