Add golangci-lint config

[hi-rai]

Add golangci-lint config based on https://github.com/maratori/golangci-lint-config/blob/v2.7.2/.golangci.yml and also fixed flagged issues

[gemini-code-assist]

Summary of Changes

Hello @hi-rai, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances code quality and maintainability by integrating golangci-lint with a robust and opinionated configuration. The primary goal is to establish consistent coding standards and proactively identify potential issues. Beyond the linter setup, the PR also includes several code modernizations, such as adopting the any type parameter and for range loops, and applies various minor fixes to align the existing codebase with the new linting rules.

Highlights

• Static Analysis Integration: Introduced golangci-lint with a comprehensive configuration based on maratori/golangci-lint-config v2.7.2 to enforce code quality and style.
• Linter Configuration Customization: Tailored the linter setup by enabling gci and gofumpt formatters, configuring gci import sections, and disabling specific linters like gochecknoglobals, mnd, nilnil, and testpackage to suit project needs.
• Go Code Modernization: Updated various function signatures to use the any type parameter instead of interface{}, and refactored for loops to use for range syntax, leveraging modern Go language features.
• Codebase Refinements: Applied fixes across several files to address issues flagged by the newly introduced linter, including improved error handling, nolint directives, and reflect.TypeFor usage.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/ci.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a golangci-lint configuration and applies the automatic fixes it suggests. This is a great step towards improving code quality and consistency. The new configuration is quite strict, which is beneficial in the long run. The code changes mostly involve modernizing the Go code, such as using any over interface{}, and fixing potential issues like unchecked errors.

I've identified a couple of critical issues that would prevent the code from compiling or the CI from running. These include an incorrect version in the golangci-lint configuration, a broken installation command in the Makefile, and a call to a non-existent function. I've also included some minor suggestions to improve code idiomaticity.

[gemini-code-assist]

The version key for the golangci-lint configuration file format should be 1. Using 2 might cause issues with parsing the configuration file. According to the official documentation, 1 is the only valid version for the configuration file format.

version: 1