Add "bucket explorer" to helloworld app #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some fileserver and upload handler to the helloworld app. Those will only be served if a bucket is mounted at a specific location Signed-off-by: Benjamin Isinger <Benjamin.Isinger@ibm.com>
isibeni
force-pushed
the
helloworld-bucket
branch
from
8ec6a1c to
77df2a0
Compare
reggeenr
approved these changes
Jul 18, 2025
Collaborator
reggeenr
left a comment
reggeenr
left a comment
There was a problem hiding this comment.
LGTM - Great idea
We should add a remark to the Readme to explain how this helloworld app can be utilized to verify COS mounts
Member
Author
|
Will do, when the docs are updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some fileserver and upload handler to the helloworld app.
Those will only be served if a bucket is mounted at a specific location