Skip to content

fix: use DefinitionTooltip for similarity score tags #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zvonimirfras merged 1 commit into from
Sep 1, 2026
Merged

fix: use DefinitionTooltip for similarity score tags #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions frontend/src/app/components/SimilarityScoreDisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Tag, InlineLoading, Tooltip } from '@carbon/react';
import { Tag, InlineLoading, DefinitionTooltip } from '@carbon/react';
import { Error } from '@carbon/icons-react';
import { TestResult } from '@/lib/api';
import styles from './SimilarityScoreDisplay.module.scss';
Expand Down Expand Up @@ -37,11 +37,11 @@ export default function SimilarityScoreDisplay({ result, score, size = 'sm' }: S
// If a simple score is provided, use it directly
if (typeof score === 'number') {
return (
<Tooltip content={getScoreDescription(score)}>
<DefinitionTooltip definition={getScoreDescription(score)} openOnHover>
<Tag type={getScoreColor(score)} size={size}>
{score.toFixed(1)}%
</Tag>
</Tooltip>
</DefinitionTooltip>
);
}

Expand Down Expand Up @@ -70,23 +70,26 @@ export default function SimilarityScoreDisplay({ result, score, size = 'sm' }: S
// Scoring failed
if (similarity_scoring_status === 'failed') {
return (
<Tooltip content={similarity_scoring_error || 'Unknown error occurred during scoring'}>
<DefinitionTooltip
definition={similarity_scoring_error || 'Unknown error occurred during scoring'}
openOnHover
>
<div className={styles.errorContainer}>
<Error size={16} />
<span>Failed</span>
</div>
</Tooltip>
</DefinitionTooltip>
);
}

// Scoring completed
if (similarity_scoring_status === 'completed' && typeof similarity_score === 'number') {
return (
<Tooltip content={getScoreDescription(similarity_score)}>
<DefinitionTooltip definition={getScoreDescription(similarity_score)} openOnHover>
<Tag type={getScoreColor(similarity_score)} size={size}>
{similarity_score}%
</Tag>
</Tooltip>
</DefinitionTooltip>
);
}

Expand Down
Loading