-
Notifications
You must be signed in to change notification settings - Fork 44
feat(IAM Policy Management): Updated role template references changes and test cases #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bhavana Bellamgari seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code was generated into the wrong place. It's in the project root, however it should be in the modules directory. Please fix this! There are almost 400 changes in this PR because of this.
|
Code looks good, see comment on goSDK PR (and other SDKs): This one need CLA like python PR. Maybe just a recheck: #288 (comment)? |
… and test cases Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
c19e064 to
c68a091
Compare
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com> Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com> Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
c68a091 to
e0a9c61
Compare
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com> Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com> Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com> Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com> Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com> Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com> Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com> Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com> Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com> Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
e0a9c61 to
be03467
Compare
|
Closing this in favor of #289 |
PR summary
This PR includes changes for role_template_references changes for policy template creation.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Currently we do not support role_template_references in policy templates. With this new behaviour, we are adding that functionality
Does this PR introduce a breaking change?
Other information
https://github.ibm.com/IAM/AM-issues/issues/4045