Skip to content

Conversation

@bbellamgari
Copy link
Contributor

PR summary

This PR includes changes for role_template_references changes for policy template creation.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Currently we do not support role_template_references in policy templates. With this new behaviour, we are adding that functionality

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

https://github.ibm.com/IAM/AM-issues/issues/4045

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bbellamgari
❌ Bhavana Bellamgari


Bhavana Bellamgari seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pyrooka pyrooka self-requested a review December 8, 2025 10:47
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code was generated into the wrong place. It's in the project root, however it should be in the modules directory. Please fix this! There are almost 400 changes in this PR because of this.

@swcolley
Copy link
Contributor

Code looks good, see comment on goSDK PR (and other SDKs):
IBM/platform-services-go-sdk#418 (review)

This one need CLA like python PR. Maybe just a recheck: #288 (comment)?
Either that or the commit messages need to be signed off as your email and it can verify that you have signed the agreement.

Bhavana Bellamgari added 2 commits December 10, 2025 12:46
… and test cases

Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
@bbellamgari bbellamgari force-pushed the gen_sdk_role_template_references branch from c19e064 to c68a091 Compare December 10, 2025 07:17
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
@bbellamgari bbellamgari force-pushed the gen_sdk_role_template_references branch from c68a091 to e0a9c61 Compare December 10, 2025 07:21
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Signed-off-by: Bhavana Bellamgari <bhavana.bellamgari@gmail.com>
@bbellamgari bbellamgari force-pushed the gen_sdk_role_template_references branch from e0a9c61 to be03467 Compare December 10, 2025 10:02
@pyrooka
Copy link
Member

pyrooka commented Dec 10, 2025

Closing this in favor of #289

@pyrooka pyrooka closed this Dec 10, 2025
@pyrooka pyrooka deleted the gen_sdk_role_template_references branch December 10, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants