Open
Conversation
bosilca
force-pushed
the
topic/batched_tasks
branch
from
2c004b1 to
fffc3ec
Compare
The idea is the following: - tasks incarnations (aka. BODY) can be marked with the "batch" property allowing the runtime to provide the task with the entire list of ready tasks of the execution stream instead of just extracting the head. - this list of ready tasks is in fact a ring, that can then be trimmed by the kernel and divided into batch and the rest. The rest of the tasks will be left in the ring, while the batch group will be submitted for execution. - the kernel also needs to provide a callback into the gpu_task complete_stage, such that the runtime can call the specialized function able to complete all batched tasks. Signed-off-by: George Bosilca <gbosilca@nvidia.com>
bosilca
force-pushed
the
topic/batched_tasks
branch
from
fffc3ec to
9998554
Compare
abouteiller
reviewed
Feb 26, 2025
| * from the task ring, and singleton it or replace it with the aggregated tasks | ||
| * as necessary. | ||
| */ | ||
| goto move_forward_with_this_task; |
Contributor
There was a problem hiding this comment.
can we avoid using a goto here?
| if( NULL != type_property) { | ||
|
|
||
| if (!strcasecmp(type_property->expr->jdf_var, "cuda") | ||
| if (!strncasecmp(type_property->expr->jdf_var, "cuda", 4) /* for batched */ |
Contributor
There was a problem hiding this comment.
Looks like a leftover from a prior iteration of that patchset that used the type=cuda_batched instead of adding a new batched property.
I assume the expectation is that we can have batched and non batched CUDA bodies simultaneously. Did you test this works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is the following: