Kvm/snapshot#70
Open
robban-github wants to merge 29 commits into
Open
Conversation
jonathanthiry
requested changes
Jan 9, 2026
Contributor
jonathanthiry
left a comment
jonathanthiry
left a comment
There was a problem hiding this comment.
It looks like this PR contains a few different things. Based on its name and description, I would assume that it should be about taking KVM snapshots but contains other things as well. Could it be broken in several PRs?
It would also be helpful to have a longer description explaining what it is about and how it works.
I see that there are unresolved merge conflicts that should be fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is tested against a virtual machine "icos-srv1" running on the ICOS hypervisor icos-kronos.