Skip to content

fix: airfoil optimize bugs#246

Open
cashend wants to merge 11 commits intomainfrom
fix/airfoil-optimize-bugs
Open

fix: airfoil optimize bugs#246
cashend wants to merge 11 commits intomainfrom
fix/airfoil-optimize-bugs

Conversation

@cashend
Copy link
Copy Markdown
Contributor

@cashend cashend commented Apr 4, 2026

Description

This branch fixes some recently added bugs in airfoil optimize, and makes changes to the airfoil SLURM optimization tooling:

  1. Bug fixes in simulate_jobs.py (optimize_slurm): Fixes to TMPDIR (relevant to running on HPC), Mach argument passing typo, and opt_alpha extraction that were causing incorrect behavior in the optimizer.

  2. New script (dataset_slurm_airfoil_optimize.py): Adds a dataset generation script (now tested) that runs the aerodynamic optimizer over a grid of starting designs and sampled flow conditions (Mach, Reynolds, angle of attack) using SLURM job arrays.

  3. Changes to conventional-commits checking behavior (pre-commit.yaml) : The conventional-commit-lint check was using base.sha, which resolves to the merge-base commit and can include historical commits from main that predate this repo's adoption of conventional commits. Changed to use origin/main instead, so only commits not yet in main are linted.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files
  • I have run ruff check . and ruff format
  • I have run mypy .
  • I have commented my code, particularly in hard-to-understand areas
  • [N/A] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Merge remote-tracking branch 'public/main'
- Set TMPDIR to a per-study mpi_tmp/ directory to fix issues on HPC systems.
- Fix mach=args.reynolds typo in optimize() call to __design_to_simulator_input
- Extract optimized angle_of_attack from history instead of returning the starting value
@cashend cashend changed the title Fix/airfoil optimize bugs fix: airfoil optimize bugs Apr 4, 2026
@cashend cashend force-pushed the fix/airfoil-optimize-bugs branch from 80aad88 to c56de8c Compare April 4, 2026 13:13
@cashend cashend requested a review from g-braeunlich April 4, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants