Open
Conversation
- Set TMPDIR to a per-study mpi_tmp/ directory to fix issues on HPC systems. - Fix mach=args.reynolds typo in optimize() call to __design_to_simulator_input - Extract optimized angle_of_attack from history instead of returning the starting value
80aad88 to
c56de8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch fixes some recently added bugs in airfoil optimize, and makes changes to the airfoil SLURM optimization tooling:
Bug fixes in
simulate_jobs.py(optimize_slurm): Fixes toTMPDIR(relevant to running on HPC), Mach argument passing typo, andopt_alphaextraction that were causing incorrect behavior in the optimizer.New script (
dataset_slurm_airfoil_optimize.py): Adds a dataset generation script (now tested) that runs the aerodynamic optimizer over a grid of starting designs and sampled flow conditions (Mach, Reynolds, angle of attack) using SLURM job arrays.Changes to conventional-commits checking behavior (
pre-commit.yaml) : The conventional-commit-lint check was using base.sha, which resolves to the merge-base commit and can include historical commits from main that predate this repo's adoption of conventional commits. Changed to use origin/main instead, so only commits not yet in main are linted.Fixes # (issue)
Type of change
Checklist:
pre-commitchecks withpre-commit run --all-filesruff check .andruff formatmypy .