Skip to content

Variability: Fix bug with "Adapt to extended configuration"#1726

Open
dbinkele wants to merge 18 commits intomaintenance/mps20241from
bugfix/Adapt-to-extended-configuration-#1724
Open

Variability: Fix bug with "Adapt to extended configuration"#1726
dbinkele wants to merge 18 commits intomaintenance/mps20241from
bugfix/Adapt-to-extended-configuration-#1724

Conversation

@dbinkele
Copy link
Copy Markdown
Member

fixes #1724

@kbirken kbirken changed the title fix bug & add test (#1724) Variability: Fix bug with "Adapt to extended configuration" Mar 27, 2026
@kbirken kbirken self-requested a review March 27, 2026 10:22
Copy link
Copy Markdown
Member

@kbirken kbirken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are my findings:

  • The problem described can still be reproduced. When running the "Adapt this configuration to the extended configuration" intention on the extending configuration, the attributes are set to manual (although they should be inherited). This happens independent of the owning feature in the abstract config being selected or untouched.
  • In the variability sandbox, you killed the HomeNetworkFeatures examples. Please re-instantiate it. All references in the Configuratons chunk are currently broken and the feature models HomeNetwork and Power have been deleted.
  • CHANGELOG should be updated.

Pls. also fix dirty files, squash commits and finally merge from mps20241.

@dbinkele
Copy link
Copy Markdown
Member Author

dbinkele commented Apr 7, 2026

@kbirken Please have a look once more. If all is OK, I can squash the whole thing

@kbirken
Copy link
Copy Markdown
Member

kbirken commented Apr 14, 2026

  • The problem described can still be reproduced. When running the "Adapt this configuration to the extended configuration" intention on the extending configuration, the attributes are set to manual (although they should be inherited).

This is fixed now. However, if after this test the value of an attribute in the abstract config is being changed, then the same attribute in the extending configuration will not get the new inherited value (neither automatically nor by running the "Adapt..." intention). This can be tested with the AttrPlay sandbox model.

This issue wasn't mentioned in the ticket, but probably it hasn't been visible before due to the previous problem. But I believe it should also be fixed in this PR.

@dbinkele
Copy link
Copy Markdown
Member Author

@kbirken your finding has been addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants