Variability: Fix bug with "Adapt to extended configuration"#1726
Open
dbinkele wants to merge 18 commits intomaintenance/mps20241from
Open
Variability: Fix bug with "Adapt to extended configuration"#1726dbinkele wants to merge 18 commits intomaintenance/mps20241from
dbinkele wants to merge 18 commits intomaintenance/mps20241from
Conversation
kbirken
requested changes
Mar 27, 2026
Member
kbirken
left a comment
There was a problem hiding this comment.
Here are my findings:
- The problem described can still be reproduced. When running the "Adapt this configuration to the extended configuration" intention on the extending configuration, the attributes are set to manual (although they should be
inherited). This happens independent of the owning feature in the abstract config being selected or untouched. - In the variability sandbox, you killed the
HomeNetworkFeaturesexamples. Please re-instantiate it. All references in theConfiguratonschunk are currently broken and the feature modelsHomeNetworkandPowerhave been deleted. - CHANGELOG should be updated.
Pls. also fix dirty files, squash commits and finally merge from mps20241.
Member
Author
|
@kbirken Please have a look once more. If all is OK, I can squash the whole thing |
…xtended-configuration-#1724
…xtended-configuration-#1724
…x/Adapt-to-extended-configuration-#1724 # Conflicts: # CHANGELOG.md
Member
This is fixed now. However, if after this test the value of an attribute in the abstract config is being changed, then the same attribute in the extending configuration will not get the new inherited value (neither automatically nor by running the "Adapt..." intention). This can be tested with the This issue wasn't mentioned in the ticket, but probably it hasn't been visible before due to the previous problem. But I believe it should also be fixed in this PR. |
Member
Author
|
@kbirken your finding has been addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1724