Support for enforcing vertical layout of enum declarations#1737
Merged
wsafonov merged 2 commits intomaintenance/mps20241from Apr 16, 2026
Merged
Support for enforcing vertical layout of enum declarations#1737wsafonov merged 2 commits intomaintenance/mps20241from
wsafonov merged 2 commits intomaintenance/mps20241from
Conversation
kbirken
previously approved these changes
Apr 14, 2026
Member
kbirken
left a comment
kbirken
left a comment
There was a problem hiding this comment.
Looks good and works nicely, approved. One proposal though: There is a policy for capitalization in descriptions of intentions:
Warning: Naming policies violated: all words except prepositions, articles and particles should be capitalized.
Maybe the new intention should adhere to this policy (although the warning is not displayed because of the .format(...)).
wsafonov
force-pushed
the
feature/enums-vertical-formatting
branch
from
6f46a92 to
86d2800
Compare
Collaborator
Author
Thanks for the hint, agree - adjusted the intention name according to the policy. |
kbirken
approved these changes
Apr 16, 2026
Member
kbirken
left a comment
kbirken
left a comment
There was a problem hiding this comment.
Looks good now, thanks for improving the intention description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1736