Skip to content

Fix TISSUE_LIBRARY undefined name error in MSOTAcuityEcho #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgroehl merged 2 commits into from
Nov 20, 2025
Merged

Fix TISSUE_LIBRARY undefined name error in MSOTAcuityEcho #434

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e74e632
Initial plan
Copilot Nov 20, 2025
f7a1418
Fix TISSUE_LIBRARY to TissueLibrary in ithera_msot_acuity.py
Copilot Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions simpa/core/device_digital_twins/pa_devices/ithera_msot_acuity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ def update_settings_for_use_of_segmentation_based_volume_creator(self, global_se
us_gel_thickness_pix = int(round(us_gel_thickness_mm/spacing_mm))
padding_dims = ((0, 0), (0, 0), (us_gel_thickness_pix, 0))
segmentation_map = np.pad(segmentation_map, padding_dims, mode='constant', constant_values=64)
segmentation_class_mapping[64] = TISSUE_LIBRARY.ultrasound_gel()
segmentation_class_mapping[64] = TissueLibrary.ultrasound_gel()
# Whilst it may seem strange, to avoid rounding differences through the pipline it is best to let the
# z dimension shift us the same rounding as the pixel thickness. (This is the same for all three layers)
z_dim_position_shift_mm += us_gel_thickness_pix * spacing_mm
Expand All @@ -266,21 +266,21 @@ def update_settings_for_use_of_segmentation_based_volume_creator(self, global_se
mediprene_layer_height_pix = int(round(mediprene_layer_height_mm/spacing_mm))
padding_dims = ((0, 0), (0, 0), (mediprene_layer_height_pix, 0))
segmentation_map = np.pad(segmentation_map, padding_dims, mode='constant', constant_values=128)
segmentation_class_mapping[128] = TISSUE_LIBRARY.mediprene()
segmentation_class_mapping[128] = TissueLibrary.mediprene()
z_dim_position_shift_mm += mediprene_layer_height_pix * spacing_mm
self.logger.debug("Added a mediprene layer to the segmentation map.")

if Tags.ADD_HEAVY_WATER in add_layers:
if heavy_water_tag is None:
heavy_water_tag = 256
segmentation_class_mapping[256] = TISSUE_LIBRARY.heavy_water()
segmentation_class_mapping[256] = TissueLibrary.heavy_water()
probe_size_mm = self.probe_height_mm
mediprene_layer_height_mm = self.mediprene_membrane_height_mm
heavy_water_layer_height_mm = probe_size_mm - current_heavy_water_depth - mediprene_layer_height_mm
heavy_water_layer_height_pix = int(round(heavy_water_layer_height_mm / spacing_mm))
padding_dims = ((0, 0), (0, 0), (heavy_water_layer_height_pix, 0))
segmentation_map = np.pad(segmentation_map, padding_dims, mode='constant', constant_values=heavy_water_tag)
segmentation_class_mapping[heavy_water_tag] = TISSUE_LIBRARY.heavy_water()
segmentation_class_mapping[heavy_water_tag] = TissueLibrary.heavy_water()
z_dim_position_shift_mm += heavy_water_layer_height_pix * spacing_mm
self.logger.debug(f"Added a {heavy_water_layer_height_pix * spacing_mm}mm heavy water layer to the"
f"segmentation map.")
Expand Down