Skip to content

fix: correct slashcommands directory path (Fixes #1)#25

Merged
TrivCodez merged 1 commit into
IN3PIRE:mainfrom
dromero14521:fix/deploy-commands-path
Apr 29, 2026
Merged

fix: correct slashcommands directory path (Fixes #1)#25
TrivCodez merged 1 commit into
IN3PIRE:mainfrom
dromero14521:fix/deploy-commands-path

Conversation

@dromero14521
Copy link
Copy Markdown
Contributor

This PR fixes the directory path in deploy-commands.js by changing 'commands' to 'slashcommands'. Claiming issue #1 from the community bounty #21.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the slash command deployment script to read command definitions from the correct directory (src/slashcommands) so deployments don’t fail due to a missing folder.

Changes:

  • Fix deploy-commands.js to load command files from slashcommands instead of commands.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/deploy-commands.js
Comment on lines +7 to 8
const commandsPath = path.join(__dirname, 'slashcommands');
const commandFiles = fs.readdirSync(commandsPath).filter(f => f.endsWith('.js'));
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR metadata says “Fixes #1”, but Issue #1 is about adding a !time prefix command; this change instead addresses bounty board Issue #21 (Critical #1: deploy-commands.js references non-existent directory). Please update the PR title/description to reference the correct issue (or remove the auto-close keyword) so the wrong issue isn’t closed.

Copilot uses AI. Check for mistakes.
@TrivCodez
Copy link
Copy Markdown
Contributor

TrivCodez commented Apr 29, 2026

Pull Request Review — Issue #1

✅ Requirements — FULLY MET

Requirement Status
Bug fix correctness
Minimal change
No breaking changes
Solves reported issue

🟢 Code Quality

This is the cleanest, most minimal fix for issue #1 among all related PRs (#23, #24, #25, #32).

What it does:

  • Changes 'commands''slashcommands' in deploy-commands.js:7
  • No other changes
  • Preserves all original functionality (global command deployment)

Why it's superior:

  • ✅ No duplicate logic
  • ✅ No aggressive error handling that breaks existing workflows
  • ✅ No removal of global command support
  • ✅ Single purpose, single change

@TrivCodez TrivCodez merged commit e527b66 into IN3PIRE:main Apr 29, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants